Hi Rob, On Jun 26, 2013, at 6:42 PM, Rob Clark wrote: > On Fri, Jun 21, 2013 at 2:52 PM, Darren Etheridge <detheridge@xxxxxx> wrote: >> The series of patches that follow are intended to address issues that >> have been found in the tilcdc drm driver. The patchset enables support >> for screen resolutions with horizontal resolutions greater than 1024 >> pixels. The patchset also addresses a limitation where certain >> monitor timings would overflow LCD controller timing registers causing >> either no monitor signal or a very corrupted display. This patchset >> will stop monitor modes from being reported as valid if the lcd >> controller cannot support them. >> >> V2: >> Fix typos in commit messages >> Add a patch that enables runtime modesetting to work correctly >> Fix an issue where the slave encoder can initialize before the i2c >> subsystem, resulting in no displays being configured. >> >> Applies cleanly on drm-next. >> >> Darren Etheridge (6): >> drm/tilcdc: support pixel widths greater than 1024 >> drm/tilcdc: adding some more devicetree config >> drm/tilcdc: fixing off by one errors found on analyzer >> drm/tilcdc: adding more guards to prevent selection of invalid modes >> drm/tilcdc: whitespace fixes and tidyup >> drm/tilcdc fixing i2c/slave initialization race >> >> Pantelis Antoniou (1): >> drm/tilcdc: Clear bits of register we're going to set. > > for the series: > Acked-by: Rob Clark <robdclark@xxxxxxxxx> > I have some more DT related patches. Turns out there are some modes that just don't get right, so I've implemented mode black-lists & white-lists based on DT properties. But they sure look generic to me. Perhaps they should be better reworked and added as general helpers for drivers to use. > the i2c/slave race thing.. well, isn't pretty.. but right now I don't > see a better way. I guess at some point we need to revisit how the > encoder-slave stuff gets loaded in drm > Oh yeah, we depend on the order of initialization for this to work. > BR, > -R > Regards -- Pantelis >> >> .../devicetree/bindings/drm/tilcdc/tilcdc.txt | 8 ++ >> drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 117 +++++++++++++++++-- >> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 25 ++++- >> drivers/gpu/drm/tilcdc/tilcdc_drv.h | 24 ++++- >> drivers/gpu/drm/tilcdc/tilcdc_regs.h | 1 + >> drivers/gpu/drm/tilcdc/tilcdc_slave.c | 53 +++++---- >> 6 files changed, 189 insertions(+), 39 deletions(-) >> _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel