Arnd Bergmann <arnd@xxxxxxxxxx> writes: Hello Arnd, > From: Arnd Bergmann <arnd@xxxxxxxx> > > The list of dependencies here is phrased as an opt-out, but this is missing > a lot of architectures that don't actually support VGA consoles, and some > of the entries are stale: > > - powerpc used to support VGA consoles in the old arch/ppc codebase, but > the merged arch/powerpc never did > > - arm lists footbridge, integrator and netwinder, but netwinder is actually > part of footbridge, and integrator does not appear to have an actual > VGA hardware, or list it in its ATAG or DT. > > - mips has a few platforms (jazz, sibyte, and sni) that initialize > screen_info, on everything else the console is selected but cannot > actually work. > > - csky, hexgagon, loongarch, nios2, riscv and xtensa are not listed > in the opt-out table and declare a screen_info to allow building > vga_con, but this cannot work because the console is never selected. > > Replace this with an opt-in table that lists only the platforms that > remain. This is effectively x86, plus a couple of historic workstation > and server machines that reused parts of the x86 system architecture. > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- Both our explanation and changes look good to me. Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
