Hi Ville,
Thank you for the review.
On Monday 24 June 2013 18:08:37 Ville Syrjälä wrote:
> On Fri, Jun 14, 2013 at 11:34:42PM +0200, Laurent Pinchart wrote:
> > The -w parameter can be used to set a property value from the command
> > line, using the target object ID and the property name.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> >
> > tests/modetest/modetest.c | 108 ++++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 106 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c
> > index 778af62..858d480 100644
> > --- a/tests/modetest/modetest.c
> > +++ b/tests/modetest/modetest.c
>
> <snip>
>
> > @@ -1008,9 +1082,20 @@ static int parse_plane(struct plane_arg *p, const
> > char *arg)>
> > return 0;
> >
> > }
> >
> > +static int parse_property(struct property_arg *p, const char *arg)
> > +{
> > + if (sscanf(arg, "%d:%32[^:]:%" SCNu64, &p->obj_id, p->name, &p-
>value)
> > != 3)
> nit: could use stringification to get rid of the magic number 32 here.
What do you mean exactly ?
> I didn't spot any real problems in the series. But I must admit that I
> mainly just glanced at most of the changes in since many of the diffs
> are a bit hard to read.
>
> I also gave it a quick try using sprites and setting a few modes. And I
> found a bug in i915 while doing that, so clearly it has already proved
> useful ;)
That's nice to know :-)
> > + return -1;
> > +
> > + p->obj_type = 0;
> > + p->name[DRM_PROP_NAME_LEN] = '\0';
> > +
> > + return 0;
> > +}
> > +
> >
> > static void usage(char *name)
> > {
> >
> > - fprintf(stderr, "usage: %s [-cdefMmPpsv]\n", name);
> > + fprintf(stderr, "usage: %s [-cdefMmPpsvw]\n", name);
> >
> > fprintf(stderr, "\n Query options:\n\n");
> > fprintf(stderr, "\t-c\tlist connectors\n");
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
