Comparisons of 'table' and 'vddc_sclk_table' with NULL are useless since 'table' and 'vddc_sclk_table' are initialized by an addresses and cannot be NULL. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Igor Artemiev <Igor.A.Artemiev@xxxxxxx> --- drivers/gpu/drm/radeon/kv_dpm.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/radeon/kv_dpm.c b/drivers/gpu/drm/radeon/kv_dpm.c index f7735da07feb..17d312ceb6ec 100644 --- a/drivers/gpu/drm/radeon/kv_dpm.c +++ b/drivers/gpu/drm/radeon/kv_dpm.c @@ -399,7 +399,7 @@ static u32 kv_convert_vid2_to_vid7(struct radeon_device *rdev, &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; u32 i; - if (vddc_sclk_table && vddc_sclk_table->count) { + if (vddc_sclk_table->count) { if (vid_2bit < vddc_sclk_table->count) return vddc_sclk_table->entries[vid_2bit].v; else @@ -421,7 +421,7 @@ static u32 kv_convert_vid7_to_vid2(struct radeon_device *rdev, &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; u32 i; - if (vddc_sclk_table && vddc_sclk_table->count) { + if (vddc_sclk_table->count) { for (i = 0; i < vddc_sclk_table->count; i++) { if (vddc_sclk_table->entries[i].v == vid_7bit) return i; @@ -561,7 +561,7 @@ static int kv_program_bootup_state(struct radeon_device *rdev) struct radeon_clock_voltage_dependency_table *table = &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; - if (table && table->count) { + if (table->count) { for (i = pi->graphics_dpm_level_count - 1; i > 0; i--) { if (table->entries[i].clk == pi->boot_pl.sclk) break; @@ -666,7 +666,7 @@ static int kv_populate_uvd_table(struct radeon_device *rdev) int ret; u32 i; - if (table == NULL || table->count == 0) + if (table->count == 0) return 0; pi->uvd_level_count = 0; @@ -737,7 +737,7 @@ static int kv_populate_vce_table(struct radeon_device *rdev) &rdev->pm.dpm.dyn_state.vce_clock_voltage_dependency_table; struct atom_clock_dividers dividers; - if (table == NULL || table->count == 0) + if (table->count == 0) return 0; pi->vce_level_count = 0; @@ -800,7 +800,7 @@ static int kv_populate_samu_table(struct radeon_device *rdev) int ret; u32 i; - if (table == NULL || table->count == 0) + if (table->count == 0) return 0; pi->samu_level_count = 0; @@ -866,7 +866,7 @@ static int kv_populate_acp_table(struct radeon_device *rdev) int ret; u32 i; - if (table == NULL || table->count == 0) + if (table->count == 0) return 0; pi->acp_level_count = 0; @@ -922,7 +922,7 @@ static void kv_calculate_dfs_bypass_settings(struct radeon_device *rdev) struct radeon_clock_voltage_dependency_table *table = &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; - if (table && table->count) { + if (table->count) { for (i = 0; i < pi->graphics_dpm_level_count; i++) { if (pi->caps_enable_dfs_bypass) { if (kv_get_clock_difference(table->entries[i].clk, 40000) < 200) @@ -1532,7 +1532,7 @@ static void kv_set_valid_clock_range(struct radeon_device *rdev, struct radeon_clock_voltage_dependency_table *table = &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; - if (table && table->count) { + if (table->count) { for (i = 0; i < pi->graphics_dpm_level_count; i++) { if ((table->entries[i].clk >= new_ps->levels[0].sclk) || (i == (pi->graphics_dpm_level_count - 1))) { @@ -1905,7 +1905,7 @@ static int kv_get_high_voltage_limit(struct radeon_device *rdev, int *limit) &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; int i; - if (table && table->count) { + if (table->count) { for (i = table->count - 1; i >= 0; i--) { if (pi->high_voltage_t && (kv_convert_8bit_index_to_voltage(rdev, table->entries[i].v) <= @@ -2149,7 +2149,7 @@ static void kv_init_graphics_levels(struct radeon_device *rdev) struct radeon_clock_voltage_dependency_table *table = &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; - if (table && table->count) { + if (table->count) { u32 vid_2bit; pi->graphics_dpm_level_count = 0; -- 2.30.2