Hi Sarah, thanks for starting this long awaited work! On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker <sarah.walker@xxxxxxxxxx> wrote: > This patch series adds the initial DRM driver for Imagination Technologies PowerVR > GPUs, starting with those based on our Rogue architecture. It's worth pointing > out that this is a new driver, written from the ground up, rather than a > refactored version of our existing downstream driver (pvrsrvkm). This seems to be a fairly good starting point, a bit of trade-off between latest-and-greatest and recent enough devices that need aftermarket support. I assume you are aware of the community existing around Series 5 (should be the immediate predecessor to Rogue?): https://github.com/openpvrsgx-devgroup/linux_openpvrsgx I don't know how active those people are these days, but I can see that a branch was updated for v6.4-rc3 just three weeks ago. https://github.com/openpvrsgx-devgroup/linux_openpvrsgx/tree/pvrsrvkm-6.4-rc3 I think it would be good for community building to make sure that you get these people involved in reviewing, especially neutral stuff like device tree bindings but also to make sure no architectural choices are done that will make it hard to retrofit a proper driver for the older engines if this community decide to work on it. Specifically I would ask that the DT bindings include all old and new PowerVR hardware in one go, unless they have very specific hardware definition needs, which I doubt. Also I think they could use your help to get the proper firmware for the older hardware licensed properly from Imagination and included into linux-firmware so they do not need to ship files on the side. Yours, Linus Walleij
