Re: [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2023/6/13 02:15, Rob Herring wrote:
On Sun, Jun 11, 2023 at 12:49 AM Sui Jingfeng <suijingfeng@xxxxxxxxxxx> wrote:
Reviewed-by: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>


On 2023/6/10 04:17, Rob Herring wrote:
On Mon, Apr 10, 2023 at 5:26 PM Rob Herring <robh@xxxxxxxxxx> wrote:
Etnaviv doesn't use anything from of_platform.h, but depends on
of.h, of_device.h, and platform_device.h which are all implicitly
included, but that is going to be removed soon.

Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
---
   drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +++-
   1 file changed, 3 insertions(+), 1 deletion(-)
Ping!

of_device.h already has 'linux/of.h' and 'linux/platform_device.h' included,

Would it be sufficient by simply including linux/of_device.h ?
That's part of what I'm trying to remove. Standard practice is to not
rely on implicit includes.

Ok, that's fine then.


Tested-by: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>


Rob

--
Jingfeng




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux