Hi Chris, On Saturday 08 June 2013 08:53:30 Chris Wilson wrote: > On Sat, Jun 08, 2013 at 09:28:17AM +0200, Laurent Pinchart wrote: > > Could you please also update Documentation/DocBook/drm.tmpl ? > > It looks out of context there, as nothing explains the hotplug -> > fill_modes -> probe -> detect loop... Sorry, I should have been more precise. You patches changes the prototype of the fill_modes() operation and the drm_helper_probe_single_connector_modes() function, documented in drm.tmpl. I'd like to keep the documentation in sync. > > How about: > > <title>Modes</title> > <synopsis>int (*fill_modes)(struct drm_connector *connector, uint32_t > max_width, uint32_t max_height, bool force);</synopsis> > <para> > Fill the mode list with all supported modes for the connector. If the > <parameter>max_width</parameter> and <parameter>max_height</parameter> > arguments are non-zero, the implementation must ignore all modes wider > than <parameter>max_width</parameter> or higher than > <parameter>max_height</parameter>. The driver may use the existing > connector status, unless <parameter>force</parameter> is passed. During > a hotplug event, the driver may already have updated its knowledge of the > output and so may simply refresh the modes list from the information it > acquired whilst handling the event. However, the caller may explicitly > request that any cached information be dropped, and for the output to be > queried for its current status and modes - under such circumstances > <parameter>force</parameter> is true. > </para> That looks good to me (I would split this in two paragraphs, but that's just nitpicking). Could you please also update the drm_helper_probe_single_connector_modes() description in drm.tmpl ? -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
