Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023/5/22 17:25, Sui Jingfeng wrote:
Hi,

On 2023/5/21 20:21, WANG Xuerui wrote:
+ * LS3A4000/LS3A5000/LS3A6000 CPU, they are equipped with on-board video RAM + * typically. While LS2K0500/LS2K1000/LS2K2000 are low cost SoCs which share
+ * the system RAM as video RAM, they don't has a dediacated VRAM.

CPU models are not typically prefixed with "LS", so "Loongson 3A4000/3A5000/3A6000".

Here is because when you do programming, variable name should prefix with letters.

Commit messages, comments, and log messages etc. are natural language, so it's better to treat them differently. No problem to keep code as-is IMO.

Also the description about the Loongson 2K series is a bit irrelevant (we're focusing on VRAM here) so you could simplify the sentence a bit.

We could reserve part of system RAM as VRAM for Loongson 2K series SoC.

Either reserved with 'of reserve memory' or  reserved by the firmware.


What's an "of reserve memory"? Is it "DeviceTree-reserved"?

The reserve ram will not accessible by kernel itself it this case, and can still be managed by ttm.

Of course. Feel free to tweak.

--
WANG "xen0n" Xuerui

Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux