> So, the driver has to be panel-fannal-c3004.c and binding to be fannal,c3004.yaml. I believe I have covered this and all the other problems in following patch which I will submit as a V3 of the conversation in a patchset together with a driver: Add dt-bindings documentation for panel-mipi-dsi-bringup which currently supports fannal,c3004 panel. Also added fannal to vendor-prefixes. Signed-off-by: Paulo Pavacic <pavacic.p@xxxxxxxxx> --- v3 changelog: - renamed yml file - refactored yml file to describe fannal,c3004 - added matrix URI to MAINTAINERS v2 changelog: - revised driver title, now describes purpose - revised description, now describes hw - revised maintainers, now has only 1 mail - removed diacritics from commit/commit author - properties/compatible is now enum - compatible using only lowercase - revised dts example - modified MAINTAINERS in this commit (instead of driver commit) - dt_bindings_check checked yml - checkpatch warning fixed --- .../bindings/display/panel/fannal,c3004.yaml | 74 +++++++++++++++++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + MAINTAINERS | 6 ++ 3 files changed, 82 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml diff --git a/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml new file mode 100644 index 000000000000..c2eea0fa8418 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml @@ -0,0 +1,74 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/fannal,c3004.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Fannal C3004373132019A MIPI-DSI + +maintainers: + - Paulo Pavacic <pavacic.p@xxxxxxxxx> + +description: | + Fannal C3004373132019A is a 480x800 panel which requires DSI DCS + initialization sequences. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - const: fannal,c3004 + + port: true + reg: true + reset-gpios: true + + vdd-supply: + description: power supply voltage + vddio-supply: + description: power supply voltage for IO + + width-mm: + description: physical panel width [mm] + height-mm: + description: physical panel height [mm] + +required: + - compatible + - reg + - reset-gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "fannal,c3004"; + reg = <0>; + pinctrl-0 = <&pinctrl_mipi_dsi_rst>; + pinctrl-names = "default"; + reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; + vdd-supply = <®1>; + vddio-supply = <®2>; + width-mm = <93>; + height-mm = <56>; + panel-timing { + clock-frequency = <27000000>; + hactive = <480>; + vactive = <800>; + hfront-porch = <30>; + hback-porch = <30>; + hsync-len = <8>; + vback-porch = <30>; + vfront-porch = <30>; + vsync-len = <8>; + }; + }; + }; +... diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 82d39ab0231b..f962750f630a 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -462,6 +462,8 @@ patternProperties: description: Facebook "^fairphone,.*": description: Fairphone B.V. + "^fannal,.*": + description: Fannal Electronics Co., Ltd "^faraday,.*": description: Faraday Technology Corporation "^fastrax,.*": diff --git a/MAINTAINERS b/MAINTAINERS index e0ad886d3163..75879341dd0b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6566,6 +6566,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml F: drivers/gpu/drm/tiny/panel-mipi-dbi.c +DRM DRIVER FOR MIPI DSI BRINGUP +M: Paulo Pavacic <pavacic.p@xxxxxxxxx> +S: Maintained +C: matrix:r/mipi-dsi-bringup:matrix.org +F: Documentation/devicetree/bindings/display/panel/panel-fannal,c3004.yaml + DRM DRIVER FOR MSM ADRENO GPU M: Rob Clark <robdclark@xxxxxxxxx> M: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> -- 2.40.1 Best regards, Paulo
