On 17/05/2023 16:52, Alexandre Bailon wrote: > From: Julien Stephan <jstephan@xxxxxxxxxxxx> > > By default we will call drm_gem_mmap() unless the apu driver has > declared it's own mmap handler. > > Signed-off-by: Julien Stephan <jstephan@xxxxxxxxxxxx> > Reviewed-by: Julien Stephan <jstephan@xxxxxxxxxxxx> One does not have to review own code. We all assume that we send good code which we do not have to review by ourselves (by the author). We also assume we make mistakes, which we cannot find, thus other person's review is important. Adding own review tag suggests you added them mechanically, so I doubt that they really happened. Anyway, your SoB is missing. Best regards, Krzysztof
