On Fri, 2023-04-28 at 11:58 -0700, Ceraolo Spurio, Daniele wrote: > Before we add the second step of the MTL HuC auth (via GSC), we need to > have the ability to differentiate between them. To do so, the huc > authentication check is duplicated for GuC and GSC auth, with meu > binaries being considered fully authenticated only after the GSC auth > step. > > To report the difference between the 2 auth steps, a new case is added > to the HuC getparam. This way, the clear media driver can start > submitting before full auth, as partial auth is enough for those > workloads. > > v2: fix authentication status check for DG2 > > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > Cc: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx> > --- > drivers/gpu/drm/i915/gt/uc/intel_huc.c | 94 +++++++++++++++++------ > drivers/gpu/drm/i915/gt/uc/intel_huc.h | 16 +++- > drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c | 4 +- > drivers/gpu/drm/i915/i915_reg.h | 3 + > include/uapi/drm/i915_drm.h | 3 +- > 5 files changed, 91 insertions(+), 29 deletions(-) > I believe you need a rebase with the PXP single session merged (the readiness code in gsccs backend). Other than that, all looks good: Reviewed-by: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx>