回复: [PATCH] drm/qxl: prevent memory leak

[周宗敏 <zhouzongmin@xxxxxxxxxx>]

Dear all:

 

Gentle ping on this patch.

 

Thanks
----

 

主　题：[PATCH] drm/qxl: prevent memory leak
日　期：2023-03-22 16:58
发件人：zhouzongmin@xxxxxxxxxx
收件人：airlied;Gerd Hoffmann;Dave Airlie;Daniel Vetter;

The allocated memory for qdev->dumb_heads should be released
in qxl_destroy_monitors_object before qxl suspend.
otherwise,qxl_create_monitors_object will be called to
reallocate memory for qdev->dumb_heads after qxl resume,
it will cause memory leak.

Signed-off-by: Zongmin Zhou
---
drivers/gpu/drm/qxl/qxl_display.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 6492a70e3c39..404b0483bb7c 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -1229,6 +1229,9 @@ int qxl_destroy_monitors_object(struct qxl_device *qdev)
if (!qdev->monitors_config_bo)
return 0;

+ kfree(qdev->dumb_heads);
+ qdev->dumb_heads = NULL;
+
qdev->monitors_config = NULL;
qdev->ram_header->monitors_config = 0;

--
2.34.1


No virus found
Checked by Hillstone Network AntiVirus