RE: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jagan,

> -----Original Message-----
> From: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> Sent: Friday, March 3, 2023 11:51 PM
> To: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>; Inki Dae <inki.dae@xxxxxxxxxxx>;
> Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>; Neil Armstrong
> <neil.armstrong@xxxxxxxxxx>; Marek Vasut <marex@xxxxxxx>; Maxime Ripard
> <mripard@xxxxxxxxxx>
> Cc: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx>; Kyungmin Park
> <kyungmin.park@xxxxxxxxxxx>; Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>;
> Tim Harvey <tharvey@xxxxxxxxxxxxx>; Adam Ford <aford173@xxxxxxxxx>; Matteo
> Lisi <matteo.lisi@xxxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-
> samsung-soc@xxxxxxxxxxxxxxx; linux-amarula <linux-
> amarula@xxxxxxxxxxxxxxxxxxxx>; Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> Subject: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge
> 
> This series supports common bridge support for Samsung MIPI DSIM
> which is used in Exynos and i.MX8MM SoC's.
> 
> The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus.
> 
> Inki Dae: please note that this series added on top of exynos-drm-next
> since few exynos dsi changes are not been part of drm-misc-next.
> Request you to pick these via exynos-drm-next, or let me know if you
> have any comments?

Seems some issue Marek found on testing. If fixed then I will try to pick this
patch series up.

To Andrzej, Neil, Robert and Laurent.
Could you give me any comment to below patch,
[drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge]  :
https://www.spinics.net/lists/dri-devel/msg385731.html

If you could kindly provide me with an Acked-by or Signed-off-by after review,
it would greatly assist me in picking up this patch series for upstream.

Thanks,
Inki Dae

> 
> Patch 0001 - 0002: find child DSI bridge and panel
> 
> Patch 0003 - 0004: optional PHY, PMS_P offset
> 
> Patch 0005       : introduce hw_type
> 
> Patch 0006	 : fixing host init
> 
> Patch 0007	 : atomic_check
> 
> Patch 0008	 : input_bus_flags
> 
> Patch 0009	 : atomic_get_input_bus_fmts
> 
> Patch 0010 - 0011: component vs bridge
> 
> Patch 0012	 : DSIM bridge
> 
> Patch 0013 - 0014: i.MX8M Mini/Nano
> 
> Patch 0015 - 0016: i.MX8M Plus
> 
> Changes for v15:
> - drop drm_of helpers
> - re-added find DSI bridge/Panel helper in dsim
> - collect RB from Marek V
> - fixed leading underscore in function names
> - commit messages updated
> - rebased on exynos-drm-next
> 
> Changes for v13:
> - remove devm call for DSI panel or bridge finding
> - rebased on drm-misc-next
> 
> Changes for v12:
> - collect RB from Marek V
> - add te_irq_handler hook
> - fix comments from Marek V
> - update atomic_get_input_bus_fmts logic
> 
> Changes for v11:
> - collect RB from Frieder Schrempf
> - collect ACK from Rob
> - collect ACK from Robert
> - fix BIT macro replacements
> - fix checkpatch --strict warnings
> - fix unneeded commit text
> - drop extra lines
> 
> Changes for v10:
> - rebase on drm-misc-next
> - add drm_of_dsi_find_panel_or_bridge
> - add devm_drm_of_dsi_get_bridge
> - fix host initialization (Thanks to Marek Szyprowski)
> - rearrange the tiny patches for easy to review
> - update simple names for enum hw_type
> - add is_hw_exynos macro
> - rework on commit messages
> 
> Changes for v9:
> - rebase on drm-misc-next
> - drop drm bridge attach fix for Exynos
> - added prepare_prev_first flag
> - added pre_enable_prev_first flag
> - fix bridge chain order for exynos
> - added fix for Exynos host init for first DSI transfer
> - added MEDIA_BUS_FMT_FIXED
> - return MEDIA_BUS_FMT_RGB888_1X24 output_fmt if supported output_fmt
>   list is unsupported.
> - added MEDIA_BUS_FMT_YUYV10_1X20
> - added MEDIA_BUS_FMT_YUYV12_1X24
> 
> Changes for v8:
> * fixed comment lines
> * fixed commit messages
> * fixed video mode bits
> * collect Marek Ack
> * fixed video mode bit names
> * update input formats logic
> * added imx8mplus support
> 
> Changes for v7:
> * fix the drm bridge attach chain for exynos drm dsi driver
> * fix the hw_type checking logic
> 
> Changes for v6:
> * handle previous bridge for exynos dsi while attaching bridge
> 
> Changes for v5:
> * bridge changes to support multi-arch
> * updated and clear commit messages
> * add hw_type via plat data
> * removed unneeded quirk
> * rebased on linux-next
> 
> Changes for v4:
> * include Inki Dae in MAINTAINERS
> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
> * update init handling to ensure host init done on first cmd transfer
> 
> Changes for v3:
> * fix the mult-arch build
> * fix dsi host init
> * updated commit messages
> 
> Changes for v2:
> * fix bridge handling
> * fix dsi host init
> * correct the commit messages
> 
> Tested in Engicam i.Core MX8M Mini SoM.
> 
> Repo:
> https://protect2.fireeye.com/v1/url?k=ba7a5cbf-dbf1498c-ba7bd7f0-000babff9bb7-
> 64eb01b9825d1cad&q=1&e=55e2423e-1b57-4c22-a4a8-
> 3dfcebdd3d9d&u=https%3A%2F%2Fgithub.com%2Fopenedev%2Fkernel%2Ftree%2Fimx8mm-
> dsi-v15
> 
> v13:
> https://lore.kernel.org/all/20230227113925.875425-1-
> jagan@xxxxxxxxxxxxxxxxxxxx/
> 
> Any inputs?
> Jagan.
> 
> Jagan Teki (14):
>   drm: exynos: dsi: Drop explicit call to bridge detach
>   drm: exynos: dsi: Lookup OF-graph or Child node devices
>   drm: exynos: dsi: Mark PHY as optional
>   drm: exynos: dsi: Add platform PLL_P (PMS_P) offset
>   drm: exynos: dsi: Introduce hw_type platform data
>   drm: exynos: dsi: Add atomic check
>   drm: exynos: dsi: Add input_bus_flags
>   drm: exynos: dsi: Add atomic_get_input_bus_fmts
>   drm: exynos: dsi: Consolidate component and bridge
>   drm: exynos: dsi: Add host helper for te_irq_handler
>   drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge
>   dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support
>   drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support
>   dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support
> 
> Marek Szyprowski (1):
>   drm: exynos: dsi: Handle proper host initialization
> 
> Marek Vasut (1):
>   drm: bridge: samsung-dsim: Add i.MX8M Plus support
> 
>  .../bindings/display/exynos/exynos_dsim.txt   |    2 +
>  MAINTAINERS                                   |    9 +
>  drivers/gpu/drm/bridge/Kconfig                |   12 +
>  drivers/gpu/drm/bridge/Makefile               |    1 +
>  drivers/gpu/drm/bridge/samsung-dsim.c         | 1965 +++++++++++++++++
>  drivers/gpu/drm/exynos/Kconfig                |    1 +
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c       | 1817 +--------------
>  include/drm/bridge/samsung-dsim.h             |  115 +
>  8 files changed, 2190 insertions(+), 1732 deletions(-)
>  create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c
>  create mode 100644 include/drm/bridge/samsung-dsim.h
> 
> --
> 2.25.1





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux