Re: [PATCH] drm/tests: helpers: Drop empty platform remove function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/24/23 19:14, Uwe Kleine-König wrote:
A remove callback just returning 0 is equivalent to no remove callback
at all. So drop the useless function.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Reviewed-by: Maíra Canal <mcanal@xxxxxxxxxx>

Best Regards,
- Maíra Canal

---
Hello,

the remove function was introduced in commit 57a84a97bbda ("drm/tests:
helpers: Make sure the device is bound").

Best regards
Uwe

  drivers/gpu/drm/tests/drm_kunit_helpers.c | 6 ------
  1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
index e98b4150f556..4df47071dc88 100644
--- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
+++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
@@ -19,14 +19,8 @@ static int fake_probe(struct platform_device *pdev)
  	return 0;
  }
-static int fake_remove(struct platform_device *pdev)
-{
-	return 0;
-}
-
  static struct platform_driver fake_platform_driver = {
  	.probe	= fake_probe,
-	.remove	= fake_remove,
  	.driver = {
  		.name	= KUNIT_DEVICE_NAME,
  	},



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux