On Mon, 13 Feb 2023 at 20:12, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Hi, > > On Mon, Feb 13, 2023 at 3:11 AM Kalyan Thota <quic_kalyant@xxxxxxxxxxx> wrote: > > > > This series will enable color features on sc7280 target which has > > primary panel as eDP > > > > The series removes DSPP allocation based on encoder type and allows > > the DSPP reservation based on user request via CTM. > > > > The series will release/reserve the dpu resources whenever there is > > a CTM enable/disable change so that DSPPs are allocated appropriately. > > > > Kalyan Thota (4): > > drm/msm/dpu: clear DSPP reservations in rm release > > drm/msm/dpu: add DSPPs into reservation upon a CTM request > > drm/msm/dpu: avoid unnecessary check in DPU reservations > > drm/msm/dpu: manage DPU resources if CTM is requested > > > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 38 ++++++++++++----------------- > > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 2 ++ > > drivers/gpu/drm/msm/msm_atomic.c | 18 ++++++++++++++ > > drivers/gpu/drm/msm/msm_drv.c | 2 +- > > drivers/gpu/drm/msm/msm_drv.h | 1 + > > 5 files changed, 38 insertions(+), 23 deletions(-) > > For whatever reason when I use "b4 shazam" on your series it yells: > > Patch failed at 0002 drm/msm/dpu: add DSPPs into reservation upon a CTM request > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > error: patch failed: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:573 > error: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: patch does not apply > hint: Use 'git am --show-current-patch=diff' to see the failed patch > > ...but then I can apply it with `git am --show-current-patch=diff | > patch -p1` and it just applies with fuzz. Presumably Abhniav / Dmitry > can do the same but it would be nice if your patch applied cleanly to > msm-next. Hopefully it is not some 'tested on 5.15' story. > In any case, I tried this patch on both a herobrine (sc7280) and > trogdor (sc7180) based board running msm-next (including the sc7280 > patch [1]). In both cases the night light on the internal display > worked fine when using ChromeOS. External night light didn't work on > either of them (as expected) because we don't have the compositor > support yet. > > I'm happy enough with: > > Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> Thanks for the testing! -- With best wishes Dmitry