Hi, On Fri, Jan 27, 2023 at 2:15 AM Kalyan Thota <quic_kalyant@xxxxxxxxxxx> wrote: > > Flush mechanism for DSPP blocks has changed in sc7280 family, it > allows individual sub blocks to be flushed in coordination with > master flush control. > > Representation: master_flush && (PCC_flush | IGC_flush .. etc ) > > This change adds necessary support for the above design. > > Changes in v1: > - Few nits (Doug, Dmitry) > - Restrict sub-block flush programming to dpu_hw_ctl file (Dmitry) > > Changes in v2: > - Move the address offset to flush macro (Dmitry) > - Separate ops for the sub block flush (Dmitry) > > Changes in v3: > - Reuse the DPU_DSPP_xx enum instead of a new one (Dmitry) > > Changes in v4: > - Use shorter version for unsigned int (Stephen) > > Changes in v5: > - Spurious patch please ignore. > > Changes in v6: > - Add SOB tag (Doug, Dmitry) > > Changes in v7: > - Cache flush mask per dspp (Dmitry) > - Few nits (Marijn) > > Changes in v8: > - Few nits (Marijn) > > Changes in v9: > - Use DSPP enum while accessing flush mask to make it readable (Dmitry) > - Few nits (Dmitry) > > Changes in v10: > - Fix white spaces in a separate patch (Dmitry) > > Changes in v11: > - Define a macro for dspp flush selection (Marijn) > - Few nits (Marijn) > > Changes in v12: > - Minor comments (reorder macros and a condition) (Marijn) > > Signed-off-by: Kalyan Thota <quic_kalyant@xxxxxxxxxxx> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 5 ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4 +++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 49 +++++++++++++++++++++++--- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 5 ++- > 5 files changed, 58 insertions(+), 7 deletions(-) There's a (trivial to resolve) merge conflict when applying this patch against msm-next. I dunno if that means you should send a v13? In any case, when using this patch together with the DSPP series [1] the internal night light works on sc7280-herobrine based boards. Thus: Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> [1] https://lore.kernel.org/r/1676286704-818-1-git-send-email-quic_kalyant@xxxxxxxxxxx/
