On Wed, May 8, 2013 at 12:22 AM, Paul Menzel <paulepanter@xxxxxxxxxxxxxxxxxxxxx> wrote: > Am Dienstag, den 07.05.2013, 12:32 -0700 schrieb Kees Cook: >> This reduces the size of the stack frame when calling request_module(). >> Performing the sprintf before the call is not needed. > > Good fine. Do you have any hard numbers for the record? > > Did you find this just by reading the code or are there any problems > with stack sizes on some systems? > > (This patch would be good alone for decreasing the number of code > lines. ;-)) No hard numbers; I just saw it while reviewing callers to request_module(). :) >> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx> >> --- >> drivers/gpu/drm/drm_encoder_slave.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) > > Acked-by: Paul Menzel <paulepanter@xxxxxxxxxxxxxxxxxxxxx> Thanks! -Kees -- Kees Cook Chrome OS Security _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
