Hi, In order to accomodate the Pi0-3 using the clk-bcm2835 and the Pi4 using the clk-raspberrypi clock drivers for the HDMI clocks, we piled a number of workarounds over the years. Since 6.2, we've switched the Pi0-3 to the clk-raspberrypi driver, so we can now remove those workarounds. Let me know what you think, Maxime To: Emma Anholt <emma@xxxxxxxxxx> To: Maxime Ripard <mripard@xxxxxxxxxx> To: David Airlie <airlied@xxxxxxxxx> To: Daniel Vetter <daniel@xxxxxxxx> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx Cc: linux-kernel@xxxxxxxxxxxxxxx Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx> --- Maxime Ripard (4): drm/vc4: hdmi: Replace hardcoded value by define drm/vc4: hdmi: Enable power domain before setting minimum Revert "drm/vc4: hdmi: Fix HSM clock too low on Pi4" Revert "drm/vc4: hdmi: Enforce the minimum rate at runtime_resume" drivers/gpu/drm/vc4/vc4_hdmi.c | 46 ++++++++++++------------------------------ drivers/gpu/drm/vc4/vc4_hdmi.h | 1 - 2 files changed, 13 insertions(+), 34 deletions(-) --- base-commit: 9fbee811e479aca2f3523787cae1f46553141b40 change-id: 20230126-rpi-display-fw-clk-cleanup-19d1b051a04c Best regards, -- Maxime Ripard <maxime@xxxxxxxxxx>