n Mon, May 6, 2013 at 10:32 AM, Alex Deucher <alexdeucher@xxxxxxxxx> wrote: > On Fri, May 3, 2013 at 7:01 PM, Benjamin Herrenschmidt > <benh@xxxxxxxxxxxxxxxxxxx> wrote: >> On Fri, 2013-05-03 at 19:43 -0300, Kleber Sacilotto de Souza wrote: >> >>> This patch series does: >>> 1. max_bus_speed is used to set the device to gen2 speeds >>> 2. on power there's no longer a conflict between the pseries call and other >>> architectures, because the overwrite is done via a ppc_md hook >>> 3. radeon is using bus->max_bus_speed instead of drm_pcie_get_speed_cap_mask >>> for gen2 capability detection >>> >>> The first patch consists of some architecture changes, such as adding a hook on >>> powerpc for pci_root_bridge_prepare, so that pseries will initialize it to a >>> function, while all other architectures get a NULL pointer. So that whenever >>> pci_create_root_bus is called, we'll get max_bus_speed properly setup from >>> OpenFirmware. >>> >>> The second patch consists of simple radeon changes not to call >>> drm_get_pcie_speed_cap_mask anymore. I assume that on x86 machines, >>> the max_bus_speed property will be properly set already. >> >> So I'm ok with the approach now and I might even put the powerpc patch >> in for 3.10 since arguably we are fixing a nasty bug (uninitialized >> max_bus_speed). >> >> David, what's your feeling about the radeon change ? It would be nice if >> that could go in soon for various distro targets :-) On the other hand >> I'm not going to be pushy if you are not comfortable with it. > > FWIW, the radeon change looks fine to me. > > Alex As said previously, looks fine to me too. Cheers, Jerome _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
