On Fri, 03 May 2013, Daniel Vetter <daniel@xxxxxxxx> wrote: > On Fri, May 03, 2013 at 11:17:42AM +0200, dl9pf@xxxxxx wrote: >> From: Jan-Simon Möller <dl9pf@xxxxxx> >> >> Description: >> intel_gmbus_is_forced_bit is no extern as its body is right below. >> Likewise for intel_gmbus_is_port_valid. >> >> This fixes a compilation issue with clang. An initial version of this patch >> was developed by PaX Team <pageexec at freemail.hu>. >> This is respin of this patch. >> >> Signed-off-by: Jan-Simon Möller <dl9pf@xxxxxx> >> CC: pageexec@xxxxxxxxxxx >> CC: daniel.vetter@xxxxxxxx >> CC: airlied@xxxxxxxx >> CC: intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> CC: dri-devel@xxxxxxxxxxxxxxxxxxxxx >> CC: linux-kernel@xxxxxxxxxxxxxxx > Picked up for -fixes, thanks for the patch. Please drop it. The patch removes the inline keyword, creating dozens of copies of the functions, and consequently loads of warnings: drivers/gpu/drm/i915/i915_drv.h:1803:13: warning: ‘intel_gmbus_is_port_valid’ defined but not used [-Wunused-function] drivers/gpu/drm/i915/i915_drv.h:1812:13: warning: ‘intel_gmbus_is_forced_bit’ defined but not used [-Wunused-function] BR, Jani. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
