On Wed, 24 Apr 2013 23:39:58 +0200, Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx> wrote : > On Wed, Apr 24, 2013 at 5:36 PM, Anisse Astier <anisse@xxxxxxxxx> wrote: > > Backlight hotkeys weren't working before on certain cedartrail laptops. > > > > The source of this problem is that the hotkeys' ASLE opregion interrupts > > were simply ignored. Driver seemed to expect the interrupt to be > > associated with a pipe, but it wasn't. > > > > Accepting the ASLE interrupt without an associated pipe event flag fixes > > the issue, the backlight code is called when needed, making the > > brightness keys work properly. > > [...] > > This also fixes backlight keys on my Asus poulsbo laptop. > > An ASLE IRQ is triggered by the BIOS when writing to a PCI config register. Some > BIOSes might trigger a pipe event at the same time but they obviously don't have > to (and I don't think they should). I'm not sure it needs to be in > psb_vdc_interrupt() but we might as well leave it there for now. > > I'll apply this to git://github.com/patjak/drm-gma500 gma500-fixes > > Thanks > Patrik Hi Patrik, When do you think you'll apply it to your repo ? Dave, do you think this could go in 3.10 ? Regards, Anisse _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
