On 12/10/22 10:21, Uwe Kleine-König wrote:
> Hello Arnd,
>
> On Fri, Dec 09, 2022 at 11:53:49PM +0100, Arnd Bergmann wrote:
>> On Fri, Dec 9, 2022, at 23:05, Uwe Kleine-König wrote:
>>> Some of these dependencies used to be sensible when only a small part of
>>> the platforms supported by ARCH=arm could be compiled together in a
>>> single kernel image. Nowadays ARCH_MULTIPLATFORM is only used as a guard
>>> for kernel options incompatible with a multiplatform image. See commit
>>> 84fc86360623 ("ARM: make ARCH_MULTIPLATFORM user-visible") for some more
>>> details.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>>
>> Makes sense,
>>
>> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Thanks. (But honestly I'm not surprised you agree to this patch after
> our conversation on irc :-)
>
This makes sense to me as well, but it would be great if someone else
from DRM can review/ack before pushing it.
Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
>>> diff --git a/drivers/gpu/drm/omapdrm/Kconfig
>>> b/drivers/gpu/drm/omapdrm/Kconfig
>>> index 455e1a91f0e5..76ded1568bd0 100644
>>> --- a/drivers/gpu/drm/omapdrm/Kconfig
>>> +++ b/drivers/gpu/drm/omapdrm/Kconfig
>>> @@ -2,7 +2,7 @@
>>> config DRM_OMAP
>>> tristate "OMAP DRM"
>>> depends on DRM && OF
>>> - depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM
>>> + depends on ARCH_OMAP2PLUS
>>> select DRM_KMS_HELPER
>>> select VIDEOMODE_HELPERS
>>> select HDMI
>>
>> Since the original purpose of the ||ARCH_MULTIPLATFORM was to allow
>> building the driver on more targets, I wonder if we should instead
>> make that ||COMPILE_TEST, which would also allow building it on
>> x86 and others.
>
> I wondered about that, too, but thought that would be a new patch.
>
Agreed that making it || COMPILE_TEST should be in a separate patch.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
