Re: [PATCH 1/2] drm: add drm_edid_to_eld helper extracting SADs from EDID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 21.04.2013 23:53, schrieb Alex Deucher:
On Fri, Apr 19, 2013 at 1:01 PM, Rafał Miłecki <zajec5@xxxxxxxxx> wrote:
Some devices (ATI/AMD cards) don't support passing ELD struct to the
hardware but just require filling specific registers and then the
hardware/firmware does the rest. In such cases we need to read the info
from SAD blocks and put them in the correct registers.

Signed-off-by: Rafał Miłecki <zajec5@xxxxxxxxx>
Thanks both patches applied.  I added a comment about needing to kfree
the returned pointer as per Christian's comment.

Found one more minor nitpick in this patch:

+               if (cea_db_tag(db) == AUDIO_BLOCK) {
+                       dbl = cea_db_payload_len(db);
+                       int j;
+

That's code after declaration and so complained on by the compiler.

Christian.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux