On Mon, Apr 22, 2013 at 1:43 AM, Rafał Miłecki <zajec5@xxxxxxxxx> wrote:
> 2013/4/19 Alex Deucher <alexdeucher@xxxxxxxxx>:
>> On Fri, Apr 19, 2013 at 2:10 AM, Rafał Miłecki <zajec5@xxxxxxxxx> wrote:
>>> 2013/4/18 <alexdeucher@xxxxxxxxx>:
>>>> - switch (radeon_encoder->encoder_id) {
>>>> - case ENCODER_OBJECT_ID_INTERNAL_KLDSCP_TMDS1:
>>>> - case ENCODER_OBJECT_ID_INTERNAL_LVTM1:
>>>> - WREG32_P(R600_AUDIO_TIMING, 0, ~0x301);
>>>> - break;
>>>> - case ENCODER_OBJECT_ID_INTERNAL_UNIPHY:
>>>> - case ENCODER_OBJECT_ID_INTERNAL_UNIPHY1:
>>>> - case ENCODER_OBJECT_ID_INTERNAL_UNIPHY2:
>>>> - case ENCODER_OBJECT_ID_INTERNAL_KLDSCP_LVTMA:
>>>> - WREG32_P(R600_AUDIO_TIMING, 0x100, ~0x301);
>>>> - break;
>>>> - default:
>>>> - dev_err(rdev->dev, "Unsupported encoder type 0x%02X\n",
>>>> - radeon_encoder->encoder_id);
>>>> - return;
>>>> - }
>>>
>>> Are you sure we can just drop that part?
>>
>> Yes we should be able to drop that part. The only relevant bits are
>> 9:8 which allows you to force which DTO is used by the audio block. 0
>> = auto, 1 = force dto0, 2 = force dto1. Additionally, that register
>> doesn't exist on evergreen and newer. On evergreen and newer there is
>> a DIG PHY register at the same offset which may explain the display
>> problems some people are experiencing.
>
> For now I can only say that fglrx seems to be changing that 0x7344:
>
> RREG32(0x00000534); -> 0x00000001 DCCG_AUDIO_DTO_SELECT
> WREG32(0x00000534, 0x00000000); DCCG_AUDIO_DTO_SELECT
Selects DTO0.
>
> RREG32(0x00007344); -> 0x00000270
> WREG32(0x00007344, 0x00000170);
Force audio to use DTO0. I think "auto" should work, but I can add
this back for dce2/3 if you'd prefer.
>
> RREG32(0x00000518); -> 0x00000000 DCCG_AUDIO_DTO0_MODULE
> WREG32(0x00000518, 0x00e297d0); DCCG_AUDIO_DTO0_MODULE
> RREG32(0x00000514); -> 0x00000000 DCCG_AUDIO_DTO0_PHASE
> WREG32(0x00000514, 0x00249f00); DCCG_AUDIO_DTO0_PHASE
>
Set the DTO0 dividers.
> I can't say how well radeon is going to work without that, just
> informing you about fglrx.
There are two dtos, you can use either one. AUDIO_DTO_SELECT selects
whether you are using DTO0 or DTO1. The dtos determine how the audio
signal is encoded so that it can be reconstructed in the sink.
24Mhz / pixel clock = AUDIO_DTO0_PHASE / AUDIO_DTO0_MODULE
The current code needs to be updated to calculate this properly at some point.
Alex
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
