On Mon, Dec 05, 2022 at 03:56:47PM +0800, ye.xingchen@xxxxxxxxxx wrote: > Subject: [PATCH linux-next] backlight: use sysfs_emit() to instead of > scnprintf() Isn't this a v2? (this isn't just a "nice to have"... I ended up delaying review for several days until I had time to look up where I had seen these changes before) > From: ye xingchen <ye.xingchen@xxxxxxxxxx> > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. > > Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx> Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx> Daniel.