Re: [PATCH] drm: tidss: Fix pixel format definition

[Aradhya Bhatia <a-bhatia1@xxxxxx>]

On 02-Dec-22 23:22, Andrew Davis wrote:
> On 12/1/22 6:18 PM, Randolph Sapp wrote:
> > There was a long-standing bug from a typo that created 2 ARGB1555 and
> > ABGR1555 pixel format entries. Weston 10 has a sanity check that alerted
> > me to this issue.
> >
> > According to the Supported Pixel Data formats table we have the later
> > entries should have been for Alpha-X instead.
>
> Fixes 32a1795f57eecc
>
> Acked-by: Andrew Davis <afd@xxxxxx>
>
> > Signed-off-by: Randolph Sapp <rs@xxxxxx>

Reviewed-by: Aradhya Bhatia <a-bhatia1@xxxxxx>

> > ---
> >   drivers/gpu/drm/tidss/tidss_dispc.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c 
> > b/drivers/gpu/drm/tidss/tidss_dispc.c
> > index ad93acc9abd2..16301bdfead1 100644
> > --- a/drivers/gpu/drm/tidss/tidss_dispc.c
> > +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
> > @@ -1858,8 +1858,8 @@ static const struct {
> >       { DRM_FORMAT_XBGR4444, 0x21, },
> >       { DRM_FORMAT_RGBX4444, 0x22, },
> > -    { DRM_FORMAT_ARGB1555, 0x25, },
> > -    { DRM_FORMAT_ABGR1555, 0x26, },
> > +    { DRM_FORMAT_XRGB1555, 0x25, },
> > +    { DRM_FORMAT_XBGR1555, 0x26, },
> >       { DRM_FORMAT_XRGB8888, 0x27, },
> >       { DRM_FORMAT_XBGR8888, 0x28, },