On Wed, Apr 17, 2013 at 05:38:57PM -0300, Paulo Zanoni wrote: > 2013/4/17 <ville.syrjala@xxxxxxxxxxxxxxx>: > > This series attempts to make our CEA mode matching recognize both the > > 60Hz and 59.94Hz variants of the modes (and similarly for 24/23.97, > > 30/29.97, etc.). > > > > The benefits should include: > > - Send the correct VIC in the AVI infoframe > > - Pick the correct RGB quantization range in automatic mode > > Everything looks correct, but I really didn't test anything. If you > apply my comments from patch 2, then you have "Reviewed-by: Paulo > Zanoni <paulo.r.zanoni@xxxxxxxxx>" for all the 4 patches. Thanks for the review. > > Optional bikeshedding: you could add a follow-up patch fixing the > comments inside edid_cea_modes to reflect the correct Hz used, > replacing, for example, "AxB@60Hz" with "AxB@59.94Hz". But I can > certainly live without this :) I think I'll defer on that one until we decide whether we want add both 60Hz and 59.94HZ versions to the connector's mode list. Daniel suggested we do it, but I disagree slightly since CEA-861 says that monitors should only advertise one variant in their detailed timings. I was thinking that we'd follow that rule here as well. But I can be easily convinced otherwise, in case someone else has an opinion... -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
