On Tue, 22 Nov 2022, "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@xxxxxxxxx> wrote: > On 11/22/2022 1:03 AM, Jani Nikula wrote: >> On Mon, 21 Nov 2022, Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> wrote: >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.h b/drivers/gpu/drm/i915/gt/uc/intel_uc.h >>> index a8f38c2c60e2..5d0f1bcc381e 100644 >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.h >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.h >>> @@ -6,6 +6,7 @@ >>> #ifndef _INTEL_UC_H_ >>> #define _INTEL_UC_H_ >>> >>> +#include "intel_gsc_uc.h" >> And thus intel_gsc_uc.h becomes another file that causes the entire >> driver to be rebuilt when modified. >> >> *sad trombone* > > I just followed the same pattern as what is done for GuC and HuC files. > What's the recommendation here? Should I split out gsc_uc_types.h from > gsc_uc.h ? Sorry for not being clear, I'm not insisting you do anything at this time. But it is something that needs to be refactored eventually. As an anecdotal data point: I just scripted all the #include dependencies across all the files in the driver into a digraph and had graphviz turn it into svg, and on my 80 cm wide 4k screen zoomed out as far as Firefox can, it's still 15 screenfuls side by side. ;D BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
