On 08/11/2022 13:46, Dmitry Baryshkov wrote: > On 08/11/2022 02:56, Bryan O'Donoghue wrote: >> Currently we do not differentiate between the various users of the >> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one >> compatible string but, the hardware does have some significant differences >> in the number of clocks. >> >> To facilitate documenting the clocks add the following compatible strings >> >> - qcom,mdss-dsi-ctrl-apq8064 > > Generic comment: I think we'd better follow the arm/qcom-soc.yaml and > use qcom,soc-something as compat string. This would leave us with > qcom,apq8064-dsi-ctrl That's a requirement. Only existing patterns are allowed to continue, but here all there is no such pattern. Best regards, Krzysztof