Re: [PATCH 1/1] drm/exynos: drm_connector: Fix error check condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27 March 2013 16:06, Inki Dae <inki.dae@xxxxxxxxxxx> wrote:
> 2013/3/21 Sachin Kamat <sachin.kamat@xxxxxxxxxx>:
>> drm_add_edid_modes() returns 0 upon failure to find any modes.
>> Hence check for 0 and not less than 0.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
>> Cc: Rahul Sharma <rahul.sharma@xxxxxxxxxxx>
>> ---
>>  drivers/gpu/drm/exynos/exynos_drm_connector.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c
>> index 4c5b685..56ac35f 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c
>> @@ -124,7 +124,7 @@ static int exynos_drm_connector_get_modes(struct drm_connector *connector)
>>                 }
>>
>>                 count = drm_add_edid_modes(connector, edid);
>> -               if (count < 0) {
>> +               if (count == 0) {
>
> Please just use 'if (!count)'

Resent the patch with the suggested change.
-- 
With warm regards,
Sachin
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux