Hi Noralf, On Tue, Aug 30, 2022 at 09:01:08PM +0200, Noralf Trønnes wrote: > > +static const struct drm_prop_enum_list tv_mode_names[] = { > > Maybe call it legacy_tv_mode_enums? > > > > > + { VC4_VEC_TV_MODE_NTSC, "NTSC", }, > > > > + { VC4_VEC_TV_MODE_NTSC_J, "NTSC-J", }, > > > > + { VC4_VEC_TV_MODE_PAL, "PAL", }, > > > > + { VC4_VEC_TV_MODE_PAL_M, "PAL-M", }, > > If you use DRM_MODE_TV_MODE_* here you don't need to translate the value > using the switch statement in get/set property, you can use the value > directly to get/set tv.mode. I'm sorry, I'm not quite sure what you mean by that. If we expose the DRM_MODE_TV_MODE_* properties there, won't that change the values the userspace will need to use to set that property? Maxime