On Fri, Aug 19, 2022 at 10:20 PM Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote: > > Use devm helpers for regulator get and enable > > NOTE: The series depends on commit > ee94aff2628b ("Devm helpers for regulator get and enable") > which currently sits in Mark's regulator/for-next > > A few* drivers seem to pattern demonstrated by pseudocode: > > - devm_regulator_get() > - regulator_enable() > - devm_add_action_or_reset(regulator_disable()) > > devm helpers for this pattern were added to remove bunch of code from remove a bunch > drivers. Typically following: > > - replace 3 calls (devm_regulator_get[_optional](), regulator_enable(), > devm_add_action_or_reset()) with just one > (devm_regulator_get_enable[_optional]()). > - drop disable callback. > > I believe this simplifies things by removing some dublicated code. duplicated > This series reowrks a few drivers. There is still plenty of fish in the reworks > sea for people who like to improve the code (or count the beans ;]). > > Finally - most of the converted drivers have not been tested (other than > compile-tested) due to lack of HW. All reviews and testing is _highly_ > appreciated (as always!). ... > docs: devres: regulator: Add new get_enable functions to devres.rst > clk: cdce925: simplify using devm_regulator_get_enable() > gpu: drm: simplify drivers using devm_regulator_*get_enable*() > hwmon: lm90: simplify using devm_regulator_get_enable() > hwmon: adm1177: simplify using devm_regulator_get_enable() hwmon uses a different pattern for the Subject line. -- With Best Regards, Andy Shevchenko