Hi Daniel, On Monday 18 March 2013 09:06:21 Daniel Vetter wrote: > On Tue, Mar 12, 2013 at 03:31:11PM +0100, Laurent Pinchart wrote: > > Property blob objects need to be destroyed when cleaning up to avoid > > memory leaks. Go through the list of all blobs in the > > drm_mode_config_cleanup() function and destroy them. > > > > The drm_mode_config_cleanup() function needs to be moved after the > > drm_property_destroy_blob() declaration. Move drm_mode_config_init() as > > well to keep the functions together. > > Imo moving drm_mode_config_init looks a bit superflous in this patch, > since there's still some other init code left around at the old place. It's not mandatory indeed, but it's a step in the right direction in my opinion. Maybe a separate patch that just moves functions around in drm_crtc.c would be a better idea :-) > Drop that code movement? I have no strong opinion, I can drop it if that's preferred. > Otherwise Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> Thank you. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
