On Thu, Aug 04, 2022 at 08:41:22PM +0800, Zheyu Ma wrote: > In the function *_set_par(), the value of 'screen_size' is > calculated by the user input. If the user provides the improper value, > the value of 'screen_size' may larger than 'info->screen_size', which > may cause a bug in the memset_io(). Hi I did not saw fbdev code in years, but should not this be already checked by *_check_var() ? arkfb_check_var(): ... /* Check whether have enough memory */ mem = ((var->bits_per_pixel * var->xres_virtual) >> 3) * var->yres_virtual; if (mem > info->screen_size) ... -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@xxxxxxxxxxxxx) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
