On Tue, 2022-07-26 at 16:40 +0200, Michal Suchánek wrote:
> Hello,
>
> On Tue, Jul 26, 2022 at 03:38:37PM +0200, Javier Martinez Canillas wrote:
> > On 7/20/22 16:27, Thomas Zimmermann wrote:
> > > Add a per-model device-function structure in preparation of adding
> > > color-management support. Detection of the individual models has been
> > > taken from fbdev's offb.
> > >
> > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > > ---
> >
> > Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> >
> > [...]
> >
> > > +static bool is_avivo(__be32 vendor, __be32 device)
> > > +{
> > > + /* This will match most R5xx */
> > > + return (vendor == 0x1002) &&
> > > + ((device >= 0x7100 && device < 0x7800) || (device >= 0x9400));
> > > +}
> >
> > Maybe add some constant macros to not have these magic numbers ?
>
> This is based on the existing fbdev implementation's magic numbers:
>
> drivers/video/fbdev/offb.c: ((*did >= 0x7100 && *did < 0x7800) ||
>
> Of course, it would be great if somebody knowledgeable could clarify
> those.
I don't think anybody remembers :-) Vendor 0x1002 is PCI_VENDOR_ID_ATI,
but the rest is basically ranges of PCI IDs for which we don't have
symbolic constants.
Cheers,
Ben.
