Hi Tomi, Thanks for the patch. On Tuesday 12 March 2013 12:19:38 Tomi Valkeinen wrote: > Structs videomode and display_timing have rather long field names for > the timing values. Nothing wrong with that as such, but this patch > changes them to abbreviations for the following reasons: > > * The timing values often need to be used in calculations, and long > field names makes their direct use clumsier. > > * The current names are a bit of a mishmash: some words are used as > such, some are shortened, and for some only first letter is used. Some > names use underscode, some don't. All this makes it difficult to > remember what the field names are. > > * The abbreviations used in this patch are very common, and there > shouldn't be any misunderstanding about their meaning. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > Cc: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx> > --- I have no strong opinion on this, but I find the existing names easier to read. I might be biased by having read them often though. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
