On 10/07/2022 11:00, Dmitry Baryshkov wrote: Thank you for your patch. There is something to discuss/improve. > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - interrupt-controller > + - "#interrupt-cells" > + - power-domains > + - clocks > + - clock-names > + - "#address-cells" > + - "#size-cells" > + - ranges > + > +patternProperties: > + "^mdp@(0|[1-9a-f][0-9a-f]*)$": You used some unusual pattern. It's just "[0-9a-f]+" - the device schema's job is not to validate patterns in unit addresses. Another question - why do you allow "@0" alone? > + type: object > + # TODO: add reference once the mdp5 is converted > + > + "^dsi@(0|[1-9a-f][0-9a-f]*)$": > + $ref: dsi-controller-main.yaml# Best regards, Krzysztof
