Hi 2013/2/25 Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>: > PSR must be enabled after transcoder and port are running. > And it is only available for HSW. > > v2: move enable/disable to intel_ddi > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_ddi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c > index 816c45c..bbfdcfd 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -1321,6 +1321,7 @@ static void intel_enable_ddi(struct intel_encoder *intel_encoder) > struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > > ironlake_edp_backlight_on(intel_dp); > + intel_edp_enable_psr(intel_dp); > } > > if (intel_crtc->eld_vld) { > @@ -1345,6 +1346,7 @@ static void intel_disable_ddi(struct intel_encoder *intel_encoder) > struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > > ironlake_edp_backlight_off(intel_dp); > + intel_edp_disable_psr(intel_dp); The spec suggests PSR should be disabled even before backlight (it also suggests audio should be disabled before backlight, and I notice this seems to be wrong in our code). > } > > tmp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD); > -- > 1.8.1.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel