Re: [PATCH] drm/mgag200: Cleanup: Remove extra variable assigns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, den 26.02.2013, 10:55 -0500 schrieb Christopher Harvey:

*assignments

> These two variables are set again immediately in 'mgag200_modeset_init'

The compiler would optimize this anyway I guess. Though now it can warn
us, if the code should ever change and these variable are not set
anymore in all cases.

> Signed-off-by: Christopher Harvey <charvey@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/mgag200/mgag200_main.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c
> index 70dd3c5..aad280a 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_main.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_main.c
> @@ -240,8 +240,6 @@ int mgag200_driver_load(struct drm_device *dev, unsigned long flags)
>  
>  	drm_mode_config_init(dev);
>  	dev->mode_config.funcs = (void *)&mga_mode_funcs;
> -	dev->mode_config.min_width = 0;
> -	dev->mode_config.min_height = 0;
>  	dev->mode_config.preferred_depth = 24;
>  	dev->mode_config.prefer_shadow = 1;

Acked-by: Paul Menzel <paulepanter@xxxxxxxxxxxxxxxxxxxxx>


Thanks,

Paul

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux