On Mon, Feb 25, 2013 at 04:01:48AM +0530, Syam Sidhardhan wrote: > The use of pointer sender should be after the NULL check. > > Signed-off-by: Syam Sidhardhan <s.syam@xxxxxxxxxxx> > --- > drivers/gpu/drm/gma500/mdfld_dsi_output.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_output.c b/drivers/gpu/drm/gma500/mdfld_dsi_output.c > index 2d4ab48..3abf831 100644 > --- a/drivers/gpu/drm/gma500/mdfld_dsi_output.c > +++ b/drivers/gpu/drm/gma500/mdfld_dsi_output.c > @@ -92,8 +92,8 @@ void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe) > { > struct mdfld_dsi_pkg_sender *sender = > mdfld_dsi_get_pkg_sender(dsi_config); > - struct drm_device *dev = sender->dev; > - struct drm_psb_private *dev_priv = dev->dev_private; > + struct drm_device *dev; > + struct drm_psb_private *dev_priv; > u32 gen_ctrl_val; > > if (!sender) { > @@ -101,6 +101,9 @@ void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe) > return; > } > > + dev = sender->dev; > + dev_priv = dev->dev_private; > + > /* Set default display backlight value to 85% (0xd8)*/ > mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1, > true); Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx> _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel