On Fri, Jun 3, 2022 at 5:38 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > > Hi Rob, > > On Fri, 3 Jun 2022 07:58:14 -0700 Rob Clark <robdclark@xxxxxxxxx> wrote: > > > > will the truncated subject confuse the scripts that look for patches > > to backport to stable, ie. do we *really* have to rewrite history to > > fix this? > > I don't know what scripts are being used and what they expect, but our > documentation says (Documentation/process/submitting-patches.rst): > > If your patch fixes a bug in a specific commit, e.g. you found an issue using > ``git bisect``, please use the 'Fixes:' tag with the first 12 characters of > the SHA-1 ID, and the one line summary. Do not split the tag across multiple > lines, tags are exempt from the "wrap at 75 columns" rule in order to simplify > parsing scripts. > > But, that being said, doing the rewrite is up to the maintainer. You > could just look at this as a learning experience and do better in the > future. Ok, I'll leave it up to airlied If you don't mind sharing, what is the script you use? We could perhaps add it to our WIP CI.. a script is much less likely to miss a check than a human, so I'm a fan of automating these sorts of checks whenever possible ;-) BR, -R > BTW, my script reacted to the missing closing quotes and parentheses, > which is more like to confuse any scripts that the actual truncation. > -- > Cheers, > Stephen Rothwell
