[ Oops. I never sent this after all. - dan ]
Hello Abhinav Kumar,
The patch d7d0e73f7de3: "drm/msm/dpu: introduce the
dpu_encoder_phys_* for writeback" from Apr 26, 2022, leads to the
following Smatch static checker warning:
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:252 dpu_encoder_phys_wb_atomic_check()
error: potentially dereferencing uninitialized 'mode'.
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
244 static int dpu_encoder_phys_wb_atomic_check(
245 struct dpu_encoder_phys *phys_enc,
246 struct drm_crtc_state *crtc_state,
247 struct drm_connector_state *conn_state)
248 {
249 struct drm_framebuffer *fb;
250 const struct drm_display_mode *mode;
^^^^^
251
--> 252 DPU_DEBUG("[atomic_check:%d, \"%s\",%d,%d]\n",
253 phys_enc->wb_idx, mode->name, mode->hdisplay, mode->vdisplay);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Uninitialized
254
255 if (!conn_state->writeback_job || !conn_state->writeback_job->fb)
256 return 0;
257
258 fb = conn_state->writeback_job->fb;
259 mode = &crtc_state->mode;
^^^^^^^^^^^^^^^^^^^^^^^^
Initialized here
260
261 if (!conn_state || !conn_state->connector) {
262 DPU_ERROR("invalid connector state\n");
263 return -EINVAL;
264 } else if (conn_state->connector->status !=
265 connector_status_connected) {
regards,
dan carpenter
