Hi! I wanted to send this patch out early to get some feedback on the layout of the code and new ConfigFS directory. I intend to follow this up with a more complete patch set that uses this to, for instance, add more connectors and toggle feature support. A few questions I had as someone new to kernel dev: 1. Would you prefer laying out all the objects right now or add them as-needed? IMO it’s nice to lay things out now to make future work that much easier. 2. Is the layout of /config/vkms/<type>s/<id>/<attributes> OK? If VKMS would eventually want to support installing multiple devices, we could do something like /config/vkms/card<N>/<type>s/<id>/<attributes>. 3. Should I split out the documention into a separate change? 4. Any other style / design thoughts? Thanks! I am excited to be reaching out and contributing. Jim Shargo (1): drm/vkms: Add basic support for ConfigFS to VKMS Documentation/gpu/vkms.rst | 23 +++++ drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/vkms/Makefile | 1 + drivers/gpu/drm/vkms/vkms_configfs.c | 129 +++++++++++++++++++++++++++ drivers/gpu/drm/vkms/vkms_drv.c | 10 +++ drivers/gpu/drm/vkms/vkms_drv.h | 25 ++++++ drivers/gpu/drm/vkms/vkms_output.c | 2 + drivers/gpu/drm/vkms/vkms_plane.c | 2 + 8 files changed, 193 insertions(+) create mode 100644 drivers/gpu/drm/vkms/vkms_configfs.c -- 2.36.0.512.ge40c2bad7a-goog
