Hello Ben Skeggs,
The patch 496a73bbecb8: "drm/nv50/pm: use hwsq for engine reclocking
too" from Jan 24, 2012, leads to the following Smatch warning:
"drivers/gpu/drm/nouveau/nv50_pm.c:638 nv50_pm_clocks_pre()
warn: 'info->mmast' might be uninitialized"
[ This Smatch check isn't ready for release yet ].
drivers/gpu/drm/nouveau/nv50_pm.c
621
622 info = kmalloc(sizeof(*info), GFP_KERNEL);
623 if (!info)
624 return ERR_PTR(-ENOMEM);
625 info->perflvl = perflvl;
626
627 /* memory: build hwsq ucode which we'll use to reclock memory.
628 * use pcie refclock if possible, otherwise use mpll */
629 info->mclk_hwsq.len = 0;
630 if (perflvl->memory) {
631 ret = calc_mclk(dev, perflvl, info);
632 if (ret)
633 goto error;
634 info->mscript = perflvl->memscript;
635 }
636
637 divs = read_div(dev);
638 mast = info->mmast;
^^^^^^^^^^^
My reading is that "info" is setup inside calc_mclk() so if
perflvl->memory is false then info->mmast isn't set.
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
