On Wed, Apr 20, 2022 at 08:47:11AM +0200, Uwe Kleine-König wrote:
> On Tue, Apr 19, 2022 at 03:21:28PM -0400, Ian Cowan wrote:
> > Removed an unnecessary semicolon at the end of a macro call
> >
> > Signed-off-by: Ian Cowan <ian@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/staging/fbtft/fbtft.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> > index 2c2b5f1c1df3..aa66760e1a9c 100644
> > --- a/drivers/staging/fbtft/fbtft.h
> > +++ b/drivers/staging/fbtft/fbtft.h
> > @@ -277,7 +277,7 @@ static const struct of_device_id dt_ids[] = { \
> > { .compatible = _compatible }, \
> > {}, \
> > }; \
> > -MODULE_DEVICE_TABLE(of, dt_ids);
> > +MODULE_DEVICE_TABLE(of, dt_ids)
>
> In fact the ; after MODULE_DEVICE_TABLE is necessary. There is only a
> single instance in the kernel without a semicolon[1]. That's in
> drivers/pci/controller/pcie-microchip-host.c and this only works because
> this driver cannot be compiled as a module and so MODULE_DEVICE_TABLE
> evaluates to nothing. Will send a patch for that one.
>
> Best regards
> Uwe
>
> [1] git grep -E '^[[:space:]]*MODULE_DEVICE_TABLE\([^;]*$'
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |
When I built this, it appeared to succeed. I used the command "make
M=/drivers/staging/fbtft modules". Is this incorrect? For reference this
is my first patch so it's highly likely I did this incorrectly.
---
Ian Cowan
