Hi Mr. Paul, On Wed, Feb 6, 2013 at 3:20 PM, Paul Menzel <paulepanter@xxxxxxxxxxxxxxxxxxxxx> wrote: > Am Mittwoch, den 06.02.2013, 09:54 +0530 schrieb Vikas Sajjan: >> Add support for parsing the display-timing node using video helper >> function. >> >> The DT node parsing and pinctrl selection is done only if 'dev.of_node' >> exists and the NON-DT logic is still maintained under the 'else' part. > > Last thing. It definitely helps review if you add instructions how to > test your change. Is there some user space command to check if the > display-timing node parsing works? > It is tested on Exynos4412 board by applying dependent patches available at http://lists.freedesktop.org/archives/dri-devel/2013-January/033998.html simply test would be to enable "boot logo" in make menuconfig, and verify whether the logo the appears or not during bootup. >> Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx> >> Signed-off-by: Vikas Sajjan <vikas.sajjan@xxxxxxxxxx> >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 41 +++++++++++++++++++++++++++--- >> 1 file changed, 37 insertions(+), 4 deletions(-) > > […] > > > Thanks, > > Paul > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel