Sylwester Nawrocki wrote: > > Hi Inki, > Hi Sylwester and Inki, > On 01/31/2013 02:30 AM, Inki Dae wrote: > >> -----Original Message----- > >> From: Sylwester Nawrocki [mailto:sylvester.nawrocki@xxxxxxxxx] > >> Sent: Thursday, January 31, 2013 5:51 AM > >> To: Inki Dae > >> Cc: Sachin Kamat; linux-media@xxxxxxxxxxxxxxx; dri- > >> devel@xxxxxxxxxxxxxxxxxxxxx; devicetree-discuss@xxxxxxxxxxxxxxxx; > >> patches@xxxxxxxxxx; s.nawrocki@xxxxxxxxxxx > >> Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based discovery > >> support for G2D > >> > >> On 01/30/2013 09:50 AM, Inki Dae wrote: > >>>> +static const struct of_device_id exynos_g2d_match[] = { > >>>> + { .compatible = "samsung,g2d-v41" }, > >>> > >>> not only Exynos5 and also Exyno4 has the g2d gpu and drm-based g2d > >>> driver shoud support for all Exynos SoCs. How about using > >>> "samsung,exynos5-g2d" instead and adding a new property 'version' to > >>> identify ip version more surely? With this, we could know which SoC > >>> and its g2d ip version. The version property could have '0x14' or > >>> others. And please add descriptions to dt document. > >> > >> Err no. Are you suggesting using "samsung,exynos5-g2d" compatible > string > >> for Exynos4 specific IPs ? This would not be correct, and you still can > > > > I assumed the version 'v41' is the ip for Exynos5 SoC. So if this version > > means Exynos4 SoC then it should be "samsung,exynos4-g2d". > > Yes, v3.0 is implemented in the S5PC110 (Exynos3110) SoCs and Exynos4210, > V4.1 can be found in Exynos4212 and Exynos4412, if I'm not mistaken. > > So we could have: > > compatible = "samsung,exynos-g2d-3.0" /* for Exynos3110, Exynos4210 */ > compatible = "samsung,exynos-g2d-4.1" /* for Exynos4212, Exynos4412 */ > In my opinion, this is better than later. Because as I said, when we can use IP version to identify, it is more clear and can be used One more, how about following? compatible = "samsung,g2d-3.0" compatible = "samsung,g2d-4.1" I think, just g2d is enough. For example, we are using it for mfc like following: compatible = "samsung.mfc-v6" > or alternatively > > compatible = "samsung,exynos3110-g2d" /* for Exynos3110, Exynos4210 */ > compatible = "samsung,exynos4212-g2d" /* for Exynos4212, Exynos4412 */ > Thanks. - Kukjin _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
