-----Original Message----- From: Jani Nikula [mailto:jani.nikula@xxxxxxxxxxxxxxx] Sent: Thursday, January 24, 2013 5:05 PM To: Su, Xuemin Cc: airlied@xxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; yanmin_zhang@xxxxxxxxxxxxxxx; He, Bo Subject: Re: [PATCH V3] drm_crtc: check if fb_create return NULL >Ah, sorry, never mind, I missed Daniel's comment. The benefit of the >BUG_ON() is making it clear what's expected of the drivers. >Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> Do you think this patch is still needed? Currently I fix a buggy function radeon_user_framebuffer_create() which returns NULL and patch is added to 3.7-stable tree. Do you think it's also needed to do something in drm_mode_addfb()? Thanks. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
