2013/1/30 Sean Paul <seanpaul@xxxxxxxxxxxx>: > On Tue, Jan 8, 2013 at 5:56 PM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: >> On 01/08/2013 01:16 PM, Sean Paul wrote: >>> Add a property to the hdmi node so we can specify the HDMI version in >>> the device tree instead of just defaulting to v1.4 with the existence of >>> the dt node. >> >> I guess this seems OK to me if required, although I'd certainly like to >> see someone familiar with the Exynos HW confirm whether this should be >> driven purely by DT compatible value for the HDMI IP block instead though. > > +inki > > Inki, does this seem reasonable to you? > Looks good to me. At least it's better than old one. I'll apply it if there is no any opinion. And one more thing, Exynos hdmi controller has no version info register so we need such thing. But in case of Mixer controller, it has the version info register so we could support all mixer controllers of Exynos SoC checking that register. So if you are planning on such thing for Mixer also then I'd recommend you to consider checking that register. Thanks, Inki Dae > > Sean > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel