Re: [PATCH] drm/i2c: Add driver for PTN3460 LVDS/DP bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 24 Jan 2013, Sean Paul <seanpaul@xxxxxxxxxxxx> wrote:
> +static int ptn3460_power_up(struct ptn3460_platform_data *pd)
> +{
> +	int ret;
> +
> +	if (pd->gpio_pd_n > 0)
> +		gpio_set_value(pd->gpio_pd_n, 1);

Hi Sean, just a random thing that caught my eye: last I checked 0 is a
valid GPIO number. You can use gpio_is_valid() on the GPIO numbers.


BR,
Jani.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux